1288193 - [webvr] Slow to enter VR

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Casey Yee]

When Entering VR, it seems to take 3-4 seconds before anything shows in the headset and when onVRPresentChange is fired.  

This causes users to either click "Enter VR" again, or think that VR is not functioning.  

Not sure if this is a Oculus issue or with something with FF?

Comment 1

[:kip (Kearwood Gilbert)]

Ideally, content should respond to the user immediately on requestPresent to prevent users from clicking multiple times while the promise is resolved; however, this delay does seem rather long and will need some investigation.

Even if not the case for currently supported VR hardware, content must assume that requestPresent could take multiple seconds due to powering up hardware or waiting for security prompts to be accepted

Comment 2

[:kip (Kearwood Gilbert)]

I have found the source of the bug.  Patch is incoming..

Comment 3

[:kip (Kearwood Gilbert)]

Attachment: Bug 1288193 - Ensure that the content process receives the presentation status of a VRDisplay immediately after adding or removing layers

- Corrects issues with the onvrdisplaypresentationchange events being delayed by up to 5 seconds.
- Caused a delay to enter or exit WebVR presentation on many sites.

Review commit: https://reviewboard.mozilla.org/r/76464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76464/

Comment 4

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8787778 [details]
Bug 1288193 - Ensure that the content process receives the presentation status of a VRDisplay immediately after adding or removing layers

https://reviewboard.mozilla.org/r/76464/#review75234

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89b9735661b9
Ensure that the content process receives the presentation status of a VRDisplay immediately after adding or removing layers r=gw280

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/89b9735661b9

Comment 7

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I re-verified using Fx56.0-build6, Fx 57.0b5 and Fx 58.0a1 (build ID: 20171004100049) on Windows 10 x64 and I can confirm this issue is fixed.