1288282 - (servo-coland) land mozilla-central's Servo/Stylo code changes to servo/servo on GitHub

Status: RESOLVED WONTFIX

(Developer Services :: Servo VCS Sync, defect, P1)

Description

[Chris Peterson [:cpeterson]]

We want Autoland to be able to pull Servo's Stylo PRs into m-c and commit Gecko's Stylo changes back to the Servo GitHub repo. We want to be able to run both Gecko's and Servo's automated tests before landing Stylo changes in either repo.

Comment 1

[Chris Peterson [:cpeterson]]

glob or Lars will be working on Servo autoland.

Comment 2

[:glob ✱]

the plan no longer includes rolling homu into autoland, updating and moving bug.

Comment 3

[:glob ✱]

Attachment: WIP Add SQS library (bug 1288282)

Add a library for listening to an SQS queue, processing messages, and returning
errors.

Review commit: https://reviewboard.mozilla.org/r/183910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183910/

Comment 4

[:glob ✱]

Attachment: WIP Add SQS daemon (bug 1288282)

Add a daemon which listens to SQS for messages, associated config, and command
line runner.

Review commit: https://reviewboard.mozilla.org/r/183912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183912/

Comment 5

[:glob ✱]

Attachment: WIP tweak logging of git and mercurial operations (bug 1288282)

Minor quality of life changes to make the logs easier to scan.

Review commit: https://reviewboard.mozilla.org/r/183914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183914/

Comment 6

[:glob ✱]

Attachment: WIP fix minor issues with github_pr and friends (bug 1288282)

Review commit: https://reviewboard.mozilla.org/r/183916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183916/

Comment 7

[:glob ✱]

Attachment: WIP add core colanding functionality for PR generation (bug 1288282)

When send a 'servo-coland' message over SQS, extract revisions from the
referenced mercurial bundle and create github pull requests from commits that
touch servo/.

Branches and PRs use the bug ID as the identifier, however each colanding
request will result in a new PR.  If a PR for the same bug was replaced, it
will be referenced in the new PR.

The PR's url will be left in a comment on the bug.

Review commit: https://reviewboard.mozilla.org/r/183918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183918/

Comment 8

[:glob ✱]

i've attached WIP patches for the core part of servo-coland - the part that creates PRs from mercurial commits.

the two other major parts that i'm still working on are:

- updating autoland-transplant to detect servo touching changes, create a bundle, upload to s3, and generate a sqs message
  (waiting on bug 1368516, but this isn't that complicated) 
- updating the overlay ext to apply the bundle when a colanded PR is incoming
  (also not complicated, the bulk of it will be error management)

Comment 9

[Chris Peterson [:cpeterson]]

status-firefox57=wontfix unless someone thinks this bug should block 57

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Err, I don't know why bugzilla changed the flags... Sorry about that, I just wanted to get ccd on this bug... I can't change it back, though I guess it doesn't really matter.

Comment 11

[:glob ✱]

the sync service is no longer running/needed.