1288649 - Fix non-unified-build errors for dom/canvas

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

It's that time again!

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1288649 - Fix non-unified-build errors. -

Review commit: https://reviewboard.mozilla.org/r/66408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66408/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1288649 - Use mfbt IsPowerOfTwo funcs in gfx/. -

While fixing non-unified-build errors in dom/canvas, I started hitting a
static_assert that we were calling IsPowerOfTwo with a signed type. It
turns out we have at least three copies of IsPowerOfTwo() in the tree.
Let's drop the non-mfbt ones.

Review commit: https://reviewboard.mozilla.org/r/66410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66410/

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1288649 - 2-arg ctors shouldn't be explicit.

Review commit: https://reviewboard.mozilla.org/r/66412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66412/

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8773648 [details]
Bug 1288649 - Use mfbt IsPowerOfTwo funcs in gfx/. -

https://reviewboard.mozilla.org/r/66410/#review63180

::: gfx/thebes/gfxUtils.h:299
(Diff revision 1)
>  /**
> - * Returns the first integer greater than or equal to |aNumber| which is a
> + * Returns the first integer greater than |aNumber| which is a power of two.
> - * power of two. Undefined for |aNumber| < 0.
>   */
> -static inline int
> +static int
>  NextPowerOfTwo(int aNumber)

Although the name for this function is not great. The semantics are the ones that we want. i.e. NextPowerOfTwo(4) == 4.

It would be better to change the existing callers to use RoundUpPow2

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1288649 - Remove NextPowerOfTwo. -

Review commit: https://reviewboard.mozilla.org/r/66602/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66602/

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: Reunify SOURCES.

Review commit: https://reviewboard.mozilla.org/r/66604/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66604/

Comment 7

[Kelsey Gilbert [:jgilbert]]

Looking green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a51457b8c9a

Comment 8

[Ethan Lin[:ethlin]]

Comment on attachment 8773647 [details]
Bug 1288649 - Fix non-unified-build errors. -

https://reviewboard.mozilla.org/r/66408/#review63462

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8773972 [details]
Bug 1288649 - Remove NextPowerOfTwo. -

https://reviewboard.mozilla.org/r/66602/#review63634

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91f0e0f0e398
Fix non-unified-build errors. - r=ethlin
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb620c9d9139
Use mfbt IsPowerOfTwo funcs in gfx/. - r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb943039fc6d
2-arg ctors shouldn't be explicit.
https://hg.mozilla.org/integration/mozilla-inbound/rev/19686b2399b5
Remove NextPowerOfTwo. - r=jrmuizel

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/91f0e0f0e398
https://hg.mozilla.org/mozilla-central/rev/cb620c9d9139
https://hg.mozilla.org/mozilla-central/rev/eb943039fc6d
https://hg.mozilla.org/mozilla-central/rev/19686b2399b5