1288985 - Fix a leak in makeTypedArrayWithTemplate

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

makeTypedArrayWithTemplate has a leak on an error path.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Fix a leak in an error path in makeTypedArrayWithTemplate

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8774163 [details] [diff] [review]
Fix a leak in an error path in makeTypedArrayWithTemplate

Review of attachment 8774163 [details] [diff] [review]:
-----------------------------------------------------------------

Apologies for the drive-by :)

::: js/src/vm/TypedArrayObject.cpp
@@ +630,5 @@
>          RootedObjectGroup group(cx, templateObj->group());
>  
>          NewObjectKind newKind = GenericObject;
>  
> +        ScopedJSFreePtr<void> buf;

IIRC, Scoped* pointers are deprecated in favor of mozilla::UniquePtr.

Comment 3

[Nicholas Nethercote [inactive]]

> IIRC, Scoped* pointers are deprecated in favor of mozilla::UniquePtr.

But UniquePtr<void> doesn't work:

> 0:05.44 ../../dist/include/mozilla/UniquePtr.h:317:4: error: cannot form a reference to 'void'
> 0:05.44   T& operator*() const { return *get(); }

:(

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8774163 [details] [diff] [review]
Fix a leak in an error path in makeTypedArrayWithTemplate

Review of attachment 8774163 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you for the patch.

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d72e8e5f5ad18d9ded651ecb1adf7060023c103
Bug 1288985 - Fix a leak in an error path in makeTypedArrayWithTemplate. r=bbouvier.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3d72e8e5f5ad