1289235 - PlatformHandleHelper's implicit conversion to PlatformHandleType fails on MSVC

Status: RESOLVED DUPLICATE of bug 1264566

(Core :: IPC, defect)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

The code:
>>  FileDescriptor::PlatformHandleHelper::operator PlatformHandleType

in ipc/glue/FileDescriptor.cpp, is failing to build on latest version of msvc. This looks to be due to the scoping rules for inner and outer types being treated differently than on other compilers. This may have changed in later versions of MSVC, as I haven't seen it previously.

As such, the PlatformHandleType needs to be explicitly namespaced:
>> FileDescriptor::PlatformHandleHelper::operator FileDescriptor::PlatformHandleType

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1289235 - Fix failing msvc compilation for PlatformHandleHelper implicit conversion.

MSVC requires explict namespacing on for the implicit conversion, which is
added in this changeset.

Review commit: https://reviewboard.mozilla.org/r/66956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66956/

Comment 2

[Robert Longson [:longsonr]]

Why is the patch private?

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Push to review being flakey, attempting to get it to play nice now.

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8774520 [details]
Bug 1289235 - Fix failing msvc compilation for PlatformHandleHelper implicit conversion.

MSVC requires explict namespacing on for the implicit conversion, which is
added in this changeset.

Review commit: https://reviewboard.mozilla.org/r/66956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66956/

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

this is fixed in a followup.