Closed
Bug 1289252
Opened 8 years ago
Closed 8 years ago
gDEBUG_LiveProtoCount does not need to be modified atomically
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
gDEBUG_LiveProtoCount is a debug-only counter of the number of live XPCWrappedNativeProtos. Currently, it is updated with PR_ATOMIC_INCREMENT/DECREMENT, presumably because XPConnect used to be multithreaded, but this is now unnecessary. This code looks essentially unchanged since the initial XPCDOM landing.
|
Assignee | |
Comment 1•8 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de6442645240
Attachment #8775205 -
Flags: review?(mrbkap)
|
||
Updated•8 years ago
|
Attachment #8775205 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 2•8 years ago
|
||
Thanks for all of the various reviews.
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/de70d037b6b9 gDEBUG_LiveProtoCount does not need to be modified atomically. r=mrbkap
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/de70d037b6b9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•