Closed
Bug 1289328
Opened 8 years ago
Closed 8 years ago
SSL_DHEGroupPrefSet: restore the ability to control the default group
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.26
People
(Reporter: KaiE, Assigned: mt)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
9.42 KB,
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
As mentioned by Martin in bug 1286141 comment 1, there's a regression, the code no longer treats the first parameter as the default group. Could you please restore the documented behavior? Thanks in advance. IMHO this should be considered a blocker for the 3.26 release.
|
Assignee | |
Comment 1•8 years ago
|
||
This should work. I've taken the tests from bug 1286141. I will check that this backports cleanly, but I think that it shouldn't hurt too much.
Attachment #8774670 -
Flags: review?(kaie)
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=f92631b5152c31558b24c5093c88e65fe938c3ad passes all tests
|
Reporter | |
Comment 3•8 years ago
|
||
Comment on attachment 8774670 [details] [diff] [review] bug1289328-1.patch r=kaie, thank you Martin!
Attachment #8774670 -
Flags: review?(kaie) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/f92631b5152c - trunk https://hg.mozilla.org/projects/nss/rev/34facc84fb44 - 3_26
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•