Closed
Bug 1289334
Opened 8 years ago
Closed 8 years ago
HTMLMediaElement::ResetConnectionState() should shut down the decoder
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(1 file)
MediaDecoder::ResetConnectionState() calls Shutdown(). It is suspicious for HTMLMediaElement to hold a decoder that is shut down which it can't do anything useful with. HTMLMediaElement::ResetConnectionState() should drop the reference and shut down the decoder as HTMLMediaElement::NetworkError() does.
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/67122/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/67122/
Attachment #8774669 -
Flags: review?(cpearce)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8774669 [details] Bug 1289334 - HTMLMediaElement::ResetConnectionState() should shut down the decoder. https://reviewboard.mozilla.org/r/67122/#review64598
Attachment #8774669 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Thanks!
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8774669 [details] Bug 1289334 - HTMLMediaElement::ResetConnectionState() should shut down the decoder. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67122/diff/1-2/
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b582a8dc13c3 HTMLMediaElement::ResetConnectionState() should shut down the decoder. r=cpearce
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b582a8dc13c3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•