Closed
Bug 1289467
Opened 8 years ago
Closed 8 years ago
Improve example codegen for maplike/setlike/iterable declarations
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(4 files, 2 obsolete files)
1.36 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
3.72 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
1.95 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
2.81 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
Right now we do some odd things in there.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8774764 -
Flags: review?(kyle)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8774765 -
Flags: review?(kyle)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8774766 -
Flags: review?(kyle)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8774767 -
Flags: review?(kyle)
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8774768 -
Flags: review?(kyle)
Assignee | ||
Updated•8 years ago
|
Attachment #8774766 -
Attachment is obsolete: true
Attachment #8774766 -
Flags: review?(kyle)
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8774769 -
Flags: review?(kyle)
Assignee | ||
Updated•8 years ago
|
Attachment #8774767 -
Attachment is obsolete: true
Attachment #8774767 -
Flags: review?(kyle)
Comment 7•8 years ago
|
||
Comment on attachment 8774764 [details] [diff] [review] part 1. Example codegen generation should print out which files it generated, so it's easy to examine them Review of attachment 8774764 [details] [diff] [review]: ----------------------------------------------------------------- I am for this.
Attachment #8774764 -
Flags: review?(kyle) → review+
Updated•8 years ago
|
Attachment #8774765 -
Flags: review?(kyle) → review+
Updated•8 years ago
|
Attachment #8774768 -
Flags: review?(kyle) → review+
Updated•8 years ago
|
Attachment #8774769 -
Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f20718aff215 part 1. Example codegen generation should print out which files it generated, so it's easy to examine them. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/22f5e81b7587 part 2. Skip example codegen for methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/d1031a67635a part 3. Skip forward-declaring types used by methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/2bf4894c52c9 part 4. Make ForwardDeclarationBuilder error out if asked to forward-declare a templated type instead of spitting out nonsense that doesn't compile. r=qdot
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f20718aff215 https://hg.mozilla.org/mozilla-central/rev/22f5e81b7587 https://hg.mozilla.org/mozilla-central/rev/d1031a67635a https://hg.mozilla.org/mozilla-central/rev/2bf4894c52c9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•