Closed
Bug 1289764
Opened 8 years ago
Closed 8 years ago
Move gHPanedWidget/gVPanedWidget to WidgetCache
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: stransky, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
10.20 KB,
patch
|
acomminos
:
review+
|
Details | Diff | Splinter Review |
10.08 KB,
patch
|
Details | Diff | Splinter Review |
Let's move other widgets to WidgetCache and use them in other widget code.
Reporter | ||
Comment 1•8 years ago
|
||
There's a patch for it, Thanks! Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=87a0051627d8
Attachment #8775293 -
Flags: review?(andrew)
Comment 2•8 years ago
|
||
Comment on attachment 8775293 [details] [diff] [review] patch Review of attachment 8775293 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, just one thing; ::: widget/gtk/WidgetStyleCache.cpp @@ +542,5 @@ > + GTK_STYLE_CLASS_PANE_SEPARATOR); > + case MOZ_GTK_SPLITTER_SEPARATOR_VERTICAL: > + // TODO - create from CSS node > + return GetWidgetStyleWithClass(MOZ_GTK_SPLITTER_VERTICAL, > + GTK_STYLE_CLASS_PANE_SEPARATOR); Since "separator" is a proper subnode of "paned", can we get that subnode here instead with CreateChildCSSNode?
Attachment #8775293 -
Flags: review?(andrew) → review+
Reporter | ||
Comment 3•8 years ago
|
||
Thanks, there's the one with CreateChildCSSNode(). Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1451b337255
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8775947 [details] [diff] [review] patch for check-in btw. It needs landed patch from Bug 1288413 before check-in.
Reporter | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/60a5e5073e1f Move gHPanedWidget/gVPanedWidget to WidgetCache, r=acomminos
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/60a5e5073e1f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•