Closed
Bug 1289811
Opened 8 years ago
Closed 8 years ago
nsIOutputStreamCallback should have a [function] attribute
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jsnajdr, Assigned: jsnajdr)
Details
Attachments
(1 file, 1 obsolete file)
|
935 bytes,
patch
|
jsnajdr
:
review+
|
Details | Diff | Splinter Review |
nsIInputStreamCallback has a [function] attribute, while nsOutputStreamCallback doesn't and needs to be implemented in JS as an object with onOutputStreamReady property.
|
Assignee | |
Comment 1•8 years ago
|
||
Asking :ttaubert for review, who added the [function] attribute to nsIInputStreamCallback in bug 720697.
Attachment #8775476 -
Flags: review?(ttaubert)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8775476 [details] [diff] [review] nsIOutputStreamCallback should have a [function] attribute Hmmm, I'm not the right person to review this. Nathan, maybe? :)
Attachment #8775476 -
Flags: review?(ttaubert) → review?(nfroyd)
|
||
Updated•8 years ago
|
Attachment #8775476 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Changed the reviewer in commit message.
Attachment #8775748 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8775476 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jsnajdr
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ab6dd1b9f840 Give nsIOutputStreamCallback a [function] attribute. r=nfroyd
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ab6dd1b9f840
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•