Closed Bug 1290603 Opened 8 years ago Closed 5 years ago

Automate tracing of the CycleDetector::Set

Categories

(Core :: JavaScript: GC, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox50 --- affected

People

(Reporter: terrence, Assigned: terrence)

References

Details

(Keywords: triage-deferred)

Attachments

(1 file)

This gets rid of some manual tracing.
Attachment #8776172 - Flags: review?(jcoppeard)
Comment on attachment 8776172 [details] [diff] [review]
7_fix_cycle_detector_set-v0.diff

Review of attachment 8776172 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Total nit, but could we add a cycleDetectorSet() method to the context to get rid of the .get()s?
Attachment #8776172 - Flags: review?(jcoppeard) → review+
Keywords: triage-deferred
Priority: -- → P3

Superseded by bug 1342345.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: