1290715 - Debugger doesn't remove green lines when I switch to another script via "Step In", "Step over", "Step out", "Resume" buttons

Status: RESOLVED WORKSFORME

(DevTools :: Debugger, defect, P2)

Description

[arni2033]

STR_1:
1. Open url [1]
2. Open debugger, set breakpoint at line with "for", click on the page
3. Click "Step In" several times until you finish debugging
4. Switch to script with breakpoint from Step 2

AR:
 Green line is still displayed. Actually, if you start debugging again, there'll be 2
 green lines in 1 script. In real life numerous green lines create a mess in scripts

ER: 
 No more than 1 green line in each script. No green lines when debugging is finished

This is regression from bug 1233927.

> [1] data:text/html,<script src="data:text/javascript,function F(){%0A  for (var i=0;i<1;i++){%0A    console.log(Date.now());%0A  }%0A}"></script><script src="data:text/javascript,onclick=function(){ F() }"></script>

Comment 1

[u554753]

Hello,

In your STR, you say to open a link in Step 1 but it doesn't seem to have a URL associated with it. Can you update that with the appropriate link? Thanks!

Comment 2

[u554753]

Sorry, misread. It was attached at the bottom of Comment 1.

Comment 3

[arni2033]

Attachment: screenshot 1 - bug 1290715, multiple green lines.png

I filed this bug from PC without Firefox installed, so description wasn't complete (see below).
Also, I'm 100% sure about my own results, but still prefer to know if somebody reproduced the bug.

This is regression from bug bug 1233927. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=f40c52c4b8005e98065133bf4baaa33b5ca62084&tochange=2572bf0929df26a694f58cc8765da73abea0f655

Url [1] in comment 0 shows the bug, but it can't show multiple green lines.
Test url [2] with the same steps, then start debugging again, to see 2 green lines in 1 script
> [2] data:text/html,<script src="data:text/javascript,function F(){%250A  for (var i=0;i<1;i++){%250A    console.log(Date.now());%250A  }%250A}"></script><script src="data:text/javascript,onclick=function(){ F() }"></script>

Comment 4

[u554753]

Reproducible on Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Not reproducible on Nightly 51 or Beta 48

Comment 5

[arni2033]

I just reproduced the bug on:
   Win7_64, Beta 48.0b10, 32bit, e10s disabled, ID 20160721144529 (2016-07-21)
   Win7_64, Beta 48.0b10, 32bit, e10s enabled,  ID 20160721144529 (2016-07-21)
   Win7_64, Aurora 49,    32bit, e10s disabled, ID 20160726004006 (2016-07-26)
   Win7_64, Aurora 49,    32bit, e10s enabled,  ID 20160726004006 (2016-07-26)

   Win7_64, Nightly 49,   32bit, e10s disabled, ID 20160526082509 (2016-05-26)
   Win7_64, Nightly 49,   32bit, e10s enabled,  ID 20160526082509 (2016-05-26)
   Win7_64, Nightly 50,   32bit, e10s disabled, ID 20160726080520 (2016-07-26)
   Win7_64, Nightly 50,   32bit, e10s enabled,  ID 20160726080520 (2016-07-26)
   Win7_64, Nightly 51,   32bit, e10s disabled, ID 20160801074053 (2016-08-01)
   Win7_64, Nightly 51,   32bit, e10s enabled,  ID 20160801074053 (2016-08-01)

Comment 6

[arni2033]

Finally made a testcase showing that it happens not just with "Step in" pressed in the end of function

STR_2:
1. Open url [3]
2. Open debugger, set breakpoints at line 2 and line 3, click on the page
3. Click "Step In" once
4. Click "Click to resume" once
5. Click "Click to resume" once

AR:  Step 4 - line 2 stays green. There're 2 green lines in 1 script.   Step 5 - line 2 stays green
ER:  No more than 1 green line in each script. No green lines when debugging is finished

> [3] data:text/html,<script src="data:text/javascript,var _get = function(x){return x.type}"></script><script src="data:text/javascript,onclick=function(e){%250A  var n = _get(e); %250A  console.log(n); %250A}"></script>

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Doesn't seem to be critical enough to be in a 48 dot release but we could take in 49 beta.

Comment 8

[Tim Nguyen :ntim]

Jason, can you take a look? It is a regression from bug 1233927.

Comment 9

[Jason Laster [:jlast]]

Thanks for bringing this up arni2033. 

We'll be releasing a new debugger frontend by default soon, so this is not a priority at the time.

Comment 10

[Jason Laster [:jlast]]

clearing the needinfo

Comment 11

[Ryan VanderMeulen [:RyanVM]]

arni2033, can you confirm that this works as expected with the new debugger frontend?

Comment 12

[arni2033]

(A) New debugger "improvement" is broken and unusable
(B) You can't expect it to fix everything. Last time I checked, it was present there.
(C) Have no time, busy with pending reports; some experienced tester should check this

Comment 13

[Jason Laster [:jlast]]

This *is* fixed in the new debugger.