Closed
Bug 1291280
Opened 8 years ago
Closed 8 years ago
Declare nsStyleImageLayers::Layer::mSourceURI as FragmentOrURI
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: u459114, Assigned: u459114)
References
Details
Attachments
(3 files)
A follow-up of bug 652991. Keep this url valid after window.history.pushState
Review commit: https://reviewboard.mozilla.org/r/69796/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69796/
Review commit: https://reviewboard.mozilla.org/r/69798/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69798/
Review commit: https://reviewboard.mozilla.org/r/69814/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69814/
Attachment #8778497 -
Flags: review?(cam)
Attachment #8778498 -
Flags: review?(cam)
Attachment #8778542 -
Flags: review?(cam)
hi heycam, This is a simple follow up of bug 652991 - replace type of mask uri from nsIURI to FragementOrURL.
Comment 5•8 years ago
|
||
Comment on attachment 8778497 [details] Bug 1291280 - Part 1. Move the definition of FragmentOrURL up. https://reviewboard.mozilla.org/r/69796/#review67016
Attachment #8778497 -
Flags: review?(cam) → review+
Comment 6•8 years ago
|
||
https://reviewboard.mozilla.org/r/69798/#review67018 ::: layout/style/nsRuleNode.cpp:6660 (Diff revision 1) > aConditions); > } > }; > > template <> > -struct BackgroundItemComputer<nsCSSValueList, nsCOMPtr<nsIURI> > > +struct BackgroundItemComputer<nsCSSValueList, FragmentOrURL > Nit: while touching this line, you can remove the space before the ">", which isn't needed these days. ::: layout/svg/nsSVGEffects.cpp:393 (Diff revision 1) > frame->GetContent()->AsElement(), nsRestyleHint(0), changeHint); > } > > NS_IMPL_ISUPPORTS(nsSVGMaskProperty, nsISupports) > > +static already_AddRefed<nsIURI> GetMaskURI(nsIFrame* aFrame, uint32_t aIndex); All the other GetXXXURI functions that were added are static methods on nsSVGEffects, so we should do the same to be consistent.
Comment 7•8 years ago
|
||
Comment on attachment 8778498 [details] Bug 1291280 - Part 2. Declare nsStyleImageLayers::Layer::mSourceURI as FragmentOrURI https://reviewboard.mozilla.org/r/69798/#review67020
Attachment #8778498 -
Flags: review?(cam) → review+
Comment 8•8 years ago
|
||
Comment on attachment 8778542 [details] Bug 1291280 - Part 3. Create mask local-ref test cases. https://reviewboard.mozilla.org/r/69814/#review67022 ::: layout/reftests/bugs/reftest.list:1970 (Diff revision 1) > > HTTP == 652991-1a.html 652991-1-ref.html > HTTP == 652991-1b.html 652991-1-ref.html > HTTP == 652991-2.html 652991-2-ref.html > HTTP == 652991-3.html 652991-3-ref.html > +HTTP == 652991-3.html 652991-3-ref.html Remove this duplicated line.
Attachment #8778542 -
Flags: review?(cam) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•8 years ago
|
||
Pushed by cku@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a854669c6103 Part 1. Move the definition of FragmentOrURL up. r=heycam https://hg.mozilla.org/integration/autoland/rev/b2d3fed9052a Part 2. Declare nsStyleImageLayers::Layer::mSourceURI as FragmentOrURI r=heycam https://hg.mozilla.org/integration/autoland/rev/2f4de63ff19e Part 3. Create mask local-ref test cases. r=heycam
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a854669c6103 https://hg.mozilla.org/mozilla-central/rev/b2d3fed9052a https://hg.mozilla.org/mozilla-central/rev/2f4de63ff19e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment 14•8 years ago
|
||
Pushed by cku@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9bd1de57490e Part 4. Fix compile error after enable-mask-as-shorthand. r=me
Comment 15•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9bd1de57490e
You need to log in
before you can comment on or make changes to this bug.
Description
•