Closed
Bug 1291390
Opened 8 years ago
Closed 8 years ago
Stylo: Wrong cascade level used for preferences stylesheet
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(3 files)
5.89 KB,
patch
|
bholley
:
review+
heycam
:
review+
|
Details | Diff | Splinter Review |
1.95 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
33.30 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
Right now we load the preferences stylesheet as an author stylesheet, rather than a user stylesheet. This causes it to take precedence over page-provided style rules, which isn't what happens in the gecko path and leads to incorrect behavior. Bug 1291376 covers larger architectural issues that I'm not worrying about in this bug.
Assignee | ||
Comment 1•8 years ago
|
||
In the next patch we want to introduce an accessor called ParsingMode, which conflicts with this one.
Attachment #8777076 -
Flags: review?(cam)
Attachment #8777076 -
Flags: review+
Assignee | ||
Comment 2•8 years ago
|
||
In practice this will be the 'agent' level rather than the 'author' level, given the SetParsingMode call immediately after creating the stylesheet. This change aligns behavior with CSSStyleSheet::ReparseSheet.
Attachment #8777077 -
Flags: review?(cam)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8777078 -
Flags: review?(cam)
Summary: Wrong cascade level used for preferences stylesheet → Stylo: Wrong cascade level used for preferences stylesheet
Updated•8 years ago
|
Attachment #8777076 -
Flags: review?(cam) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8777077 [details] [diff] [review] Part 2 - Use the parsing mode from the stylesheet when building preferences stylesheet. v1 Review of attachment 8777077 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/style/nsLayoutStylesheetCache.cpp @@ +950,5 @@ > > if (sheet->IsGecko()) { > sheet->AsGecko()->ReparseSheet(sheetText); > } else { > + sheet->AsServo()->ParseSheet(sheetText, uri, uri, nullptr, 0, sheet->AsServo()->ParsingMode()); Nit: please wrap at 80 columns.
Attachment #8777077 -
Flags: review?(cam) → review+
Updated•8 years ago
|
Attachment #8777078 -
Flags: review?(cam) → review+
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Cameron McCormack (:heycam) from comment #4) > Nit: please wrap at 80 columns. This line is removed in the third patch anyway.
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5da7a6c644a5&selectedJob=24971319
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0ee3385b2da3 Hoist the ParsingMode getter to the superclass and give it a special binary name for WebIDL. r=bholley,r=heycam https://hg.mozilla.org/integration/mozilla-inbound/rev/edd278067c96 Use the parsing mode from the stylesheet when building preferences stylesheet. r=heycam https://hg.mozilla.org/integration/mozilla-inbound/rev/d6806f6068fd Make parsing mode an immutable property of the StyleSheet. r=heycam
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0ee3385b2da3 https://hg.mozilla.org/mozilla-central/rev/edd278067c96 https://hg.mozilla.org/mozilla-central/rev/d6806f6068fd
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•