1291637 - refactor font-inflation reftests for input text

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Jeremy Chen ([e-mail])]

It appears that font-inflation/input-text-*-height-ref.html [1] are exact the same as font-inflation/input-text-*-height.html. This doesn't make sense to me. Maybe we should just remove them.


[1] http://searchfox.org/mozilla-central/rev/3df383b8552c1f8059f5c21258388ddb5a2f33d0/layout/reftests/font-inflation/input-text-1-height-ref.html
[2] http://searchfox.org/mozilla-central/rev/3df383b8552c1f8059f5c21258388ddb5a2f33d0/layout/reftests/font-inflation/input-text-1-height.html

Comment 1

[Jeremy Chen ([e-mail])]

Attachment: Bug 1291637 - remove input-text-*-height reftests.

input-text-*-height are exactly the same as input-text-*-height-ref, so these
reftests have been not functional for a while. Remove them.

Review commit: https://reviewboard.mozilla.org/r/68854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68854/

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8777261 [details]
Bug 1291637 - remove input-text-*-height reftests.

https://reviewboard.mozilla.org/r/68854/#review65936

These tests use test-pref(), which means they set different preferences for test and reference.  They're testing that the test running *with* font inflation produces the same results as the reference *without* font inflation.

You also didn't modify the reftest.list, so this patch would have turned the tree orange.

Comment 3

[Jeremy Chen ([e-mail])]

(In reply to David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) from comment #2)
> Comment on attachment 8777261 [details]
> Bug 1291637 - remove input-text-*-height reftests.
> 
> https://reviewboard.mozilla.org/r/68854/#review65936
> 
> These tests use test-pref(), which means they set different preferences for
> test and reference.  They're testing that the test running *with* font
> inflation produces the same results as the reference *without* font
> inflation.
> 
> You also didn't modify the reftest.list, so this patch would have turned the
> tree orange.

Oops. Should've notice the test-pref() settings in the reftest.list. Thank you for the review.