1291741 - Relax setTimeout throttling in background tabs when an AudioContext is present, rather than only when audio is playing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

See bug 1181073 comment 30 through 32 for an explanation as to why this may be necessary.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Relax setTimeout throttling in background tabs when an AudioContext is present, rather than only when audio is playing

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc55edd1533d
Relax setTimeout throttling in background tabs when an AudioContext is present, rather than only when audio is playing, r=bkelly

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cc55edd1533d

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Did this fix your problems with webaudio in background tabs?

Comment 5

[Soledad Penades [:sole] [:spenades]]

I will need to wait until it's in Nightly to test...

Comment 6

[Nika Layzell [:nika] (ni? for response)]

(In reply to Soledad Penades [:sole] [:spenades] from comment #5)
> I will need to wait until it's in Nightly to test...

This was landed 5 days ago, I think it's in nightly by now.

Comment 7

[Eric Shepherd [:sheppy]]

I’ve done doc updates in tandem with bug 1181073 for this (mentioning the difference between Firefox 50 and 51 but writing them up together).

Comment 8

[Soledad Penades [:sole] [:spenades]]

:mystor - I am deeply sorry that I just realised this needinfo was here. I tested this and it's still not quite as I think it should be. The rhythm keeps missing notes, but I was expecting it to keep playing as normal when in the background as the audiocontext is [should be?] active.

I realise you probably have other things in mind right now, but as an audio-on-the-web-interested-person I would love to see if there's a way this can be improved. I promise to be more needinfo-aware next time!

Apologies again! I'm truly sorry.

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

We recently changed some thing in FF55 beta and FF56 nightly.  Do those behave any differently for you?

Comment 10

[Soledad Penades [:sole] [:spenades]]

What did you change? What difference should I see? I tested today using Nightly, that's where I saw the 'not quite right' behaviour that I described in comment 8.

Comment 11

[Ben Kelly [:bkelly, not reviewing]]

Can you describe the test steps you are using?

Comment 12

[Soledad Penades [:sole] [:spenades]]

Sure!

- I am going to http://sole.github.io/test_cases/web_audio/settimeout/
- Click play
- Change to another tab so this one goes to the background

I'd expect the sound to keep playing smoothly as it is when in the foreground, but notes are skipped and so the beat is not OK

Comment 13

[Ben Kelly [:bkelly, not reviewing]]

I can reproduce.  I'm going to file a new bug.

Comment 14

[Soledad Penades [:sole] [:spenades]]

Thank you, Ben. Very appreciated considering the Quantum workload!

Comment 15

[Nika Layzell [:nika] (ni? for response)]

Sounds like Ben has this under control :). Clearing needinfo.