Closed
Bug 1292190
Opened 8 years ago
Closed 8 years ago
Baldr: fix include dependencies
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
|
12.72 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
Some of the "lightweight" (types, constants, helpers) wasm headers (WasmBinary.h/WasmTypes.h) are transitively including most of the world via builtin/SIMD.h which in turn is inverting the intended header dependency (WasmJS.h should depend on WasmTypes.h). This patch makes builtin/SIMD.h into a lightweight header by cutting the dependency on TypedObjects.h (which pulls in everything).
Attachment #8777858 -
Flags: review?(bbouvier)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8777858 [details] [diff] [review] rearrange-include-deps Review of attachment 8777858 [details] [diff] [review]: ----------------------------------------------------------------- Nice! (I assume you've checked it builds with non-unified compilation on at least one platform; this *should* not be platform dependent, but who knows)
Attachment #8777858 -
Flags: review?(bbouvier) → review+
Pushed by lwagner@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f411c2442970 Baldr: fix include dependencies (r=bbouvier)
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f411c2442970
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•