1292528 - "Dumb" download link headings should include channel description.

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Alex Gibson [:agibson]]

STR:

1.) In Firefox, go to 'about:config' and set 'javascript.enabled' to 'false'.
2.) Visit a page with multiple download buttons, such as https://www.mozilla.org/en-US/firefox/installer-help/.

Expected results:

It should be clear which channel each group of download links relates to.

Actual results:

Each download button is labelled "Download Firefox — English (US)", which gives no indication as to which is Release, Beta, Dev Edition etc.

This bug seems like a minor one, but will become more important if we start to limit serving JS to old IE browsers (bug 1287200). We could likely just reuse the strings already in the download button helper to solve this.

Comment 1

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 2

[Alex Gibson [:agibson]]

Attachment: download-headings.png

Screenshot of before/after.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/eb19dac89d152ee451e69d3de603a1fc4efa1df0
[fix bug 1292528] 'Dumb' download link headings should include channel description.

https://github.com/mozilla/bedrock/commit/7a7c7a1ec58cdbcd9560a663028dd6a6cdef168f
Merge pull request #4268 from alexgibson/bug-1292528-dumb-download-link-channel-description

[fix bug 1292528] 'Dumb' download link headings should include channe…