1292642 - CoreGraphics can still be the backend somehow

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mason Chang [Inactive] [:mchang]]

STR:

1) Change the backend to 'cairo'
2) Restart Firefox
3) Somehow, quartz is chosen as the backend.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Default to skia if we have an invalid pref for a backend

The problem was we were defaulting to CG if we had an invalid preference for the content backend. This fixes it so we default to skia.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8779030 [details] [diff] [review]
Default to skia if we have an invalid pref for a backend

Review of attachment 8779030 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure this is going far enough.

::: gfx/thebes/gfxPlatformMac.cpp
@@ +73,5 @@
>  {
>      DisableFontActivation();
>      mFontAntiAliasingThreshold = ReadAntiAliasingThreshold();
>  
> +    uint32_t canvasMask = BackendTypeBit(BackendType::SKIA) |

Is this enough?  This looks like we're setting Skia as the default, disallowing Cairo, but still allowing CG for content and canvas.  If I set the content pref to cairo,cg, and run with this change, I assert in mozilla::gfx::BorrowedCGContext::BorrowCGContextFromDrawTarget

Comment 3

[Mason Chang [Inactive] [:mchang]]

Attachment: Default to skia if we have an invalid pref for a backend

(In reply to Milan Sreckovic [:milan] from comment #2)
> Comment on attachment 8779030 [details] [diff] [review]
> Default to skia if we have an invalid pref for a backend
> 
> Review of attachment 8779030 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Not sure this is going far enough.
> 
> ::: gfx/thebes/gfxPlatformMac.cpp
> @@ +73,5 @@
> >  {
> >      DisableFontActivation();
> >      mFontAntiAliasingThreshold = ReadAntiAliasingThreshold();
> >  
> > +    uint32_t canvasMask = BackendTypeBit(BackendType::SKIA) |
> 
> Is this enough?  This looks like we're setting Skia as the default,
> disallowing Cairo, but still allowing CG for content and canvas.  If I set
> the content pref to cairo,cg, and run with this change, I assert in
> mozilla::gfx::BorrowedCGContext::BorrowCGContextFromDrawTarget

I added the code back from ESR 45 on borrowing a CG Context from DrawTargetCG. Some things are still broken, but content works. We're only keeping CG around for Jeff to test if he needs to, so it's ok if not everything works.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8779487 [details] [diff] [review]
Default to skia if we have an invalid pref for a backend

Review of attachment 8779487 [details] [diff] [review]:
-----------------------------------------------------------------

I shouldn't be the one reviewing the DrawTargetSkia changes, but since those changes are to the backend we don't support anymore, looks good to me.

Comment 5

[Mason Chang [Inactive] [:mchang]]

Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fb8c06030f4

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03b9c5797a8b
Default to skia if we have an invalid pref for a backend on OS X. r=milan

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/03b9c5797a8b