1292643 - "Ignore others" and "Save all" buttons in autoclassify should always be visible, even if you scroll down the autoclassify panel

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If there are lots of failures for a job, the autoclassify panel gets a scrollbar and you can scroll down enough that these two buttons are no longer visible, so you have to scroll back up the page to save the classifications (or ignore others).

These buttons should always be floating at the top-right corner of the panel so they can be clicked without having to scroll back up.

Comment 1

[James Graham [:jgraham]]

Yeah, I tried to make this work, but I couldn't figure out the right CSS. Using a hack like js that sets the right position in scroll handlers is going to cause jank.

Does anyone know a CSS expert we can ask?

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Can we just split the pane so the buttons are in a div that doesn't scroll and takes ~10% of the width, while the rest of the classifying UI takes the rest and scrolls? This would also help with a bug I was going to file about really long failure lines not breaking, adding horizontal scrolling and pushing the ignore/save buttons waaay off to the right.

Comment 3

[James Graham [:jgraham]]

Yes, if you want the scrollbar to the left of the buttons, I know how to make that work.

Comment 4

[Phil Ringnalda (:philor)]

Because of the workflow problem of bug 1292919, it might be better to fix this by putting the buttons in an unscrollable section on the left side, rather than on the right side of the scrollbar.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Ooh, and that would help with the "failure lines or bug summaries are too long and don't break, pushing the buttons offscreen and adding horizontal scrolling" thing, too.

Comment 6

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:autoclassify_button_scroll > mozilla:master

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8778680 [details] [review]
[treeherder] mozilla:autoclassify_button_scroll > mozilla:master

I like it.

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0d32de7ead8866cc7056289888b7373e124fc0b3
Bug 1292643 - Flip the Ignore/Save All buttons to the other side of the panel and prevent them scrolling (#1765)