Closed
Bug 1292786
Opened 8 years ago
Closed 8 years ago
Intermittent dom/canvas/test/test_capture.html | application crashed [@ mozilla::dom::HTMLCanvasElement::SetFrameCapture(already_AddRefed<mozilla::gfx::SourceSurface>)]
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: pehrsons)
References
Details
(Keywords: intermittent-failure, Whiteboard: [gfx-noted])
Attachments
(1 file)
Filed by: phil [at] philringnalda.com https://treeherder.mozilla.org/logviewer.html#?job_id=33173570&repo=mozilla-inbound http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64/1470067249/mozilla-inbound_win8_64_test-mochitest-1-bm127-tests1-windows-build1204.txt.gz
Comment 1•8 years ago
|
||
Crash dereferencing a null pointer to a surface in SetFrameCapture, because the CopySurface call in WillRefresh returned null. I am not familiar with this code so I'm not sure if the WillRefresh is responsible for not producing null pointers or if we should handle this gracefully lower down the stack, or something else. Andreas, any idea?
Flags: needinfo?(pehrson)
Whiteboard: [gfx-noted]
Assignee | ||
Comment 2•8 years ago
|
||
I think we should just avoid calling SetFrameCapture() when CopySurface() returns nullptr. I'll get to it in a bit.
Assignee: nobody → pehrson
Flags: needinfo?(pehrson)
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8781993 [details] Bug 1292786 - Don't SetFrameCapture() when CopySurface() fails. https://reviewboard.mozilla.org/r/72292/#review69884
Attachment #8781993 -
Flags: review?(nical.bugzilla) → review+
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/828e9a557da4 Don't SetFrameCapture() when CopySurface() fails. r=nical
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/828e9a557da4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•