1293043 - The icons of the Internet links are too small since the last update - not to see

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P4)

Description

[Jutta Koliofotis]

Attachment: Desktop.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160726073904

Steps to reproduce:

I like to make a link from a website too my Desktop


Actual results:

Since a while - the icons from the links are too small with a white background


Expected results:

Previously, they they were normal sized same as whit links saved from IE

Comment 1

[Tooru Fujisawa [:arai]]

I confirmed the small icon, compared to IE and Chrome, on Windows 7.

Shortcut created by IE and Chrome have large icon, but shortcut created by Firefox have small Icon.
I don't see any behavior difference between older versions of Firefox, so not sure why it started happening on reporter's env.


Here are the content of .lnk file, for https://www.mozilla.org/en-US/ , saved from IE 11, Chrome, and Firefox 48.0.

---- from IE11 (replaced some characters in title) ----

[{000214A0-0000-0000-C000-000000000046}]
Prop4=31,We're building a better Internet - Mozilla
Prop3=19,11
[{000214A0-0000-0000-C000-000000000046}.A]
Prop4=31,We're building a better Internet - Mozilla
[{000214A0-0000-0000-C000-000000000046}.W]
Prop4=31,We+IBk-re building a better Internet +IBQ- Mozilla
[{A7AF692E-098D-4C08-A225-D433CA835ED0}]
Prop5=3,0
Prop9=19,0
[InternetShortcut]
URL=https://www.mozilla.org/en-US/
IDList=
IconFile=https://www.mozilla.org/media/img/favicon/favicon-196x196.cb79ae3b6daf.png
IconIndex=1
[{9F4C2855-9F79-4B39-A8D0-E1D42DE1D5F3}]
Prop5=8,Microsoft.Website.A52A63AC.B83E2356

---- from Chrome ----

[InternetShortcut]
URL=https://www.mozilla.org/en-US/

---- from Firefox 48.0 ----

[InternetShortcut]
URL=https://www.mozilla.org/en-US/
IDList=
HotKey=0
IconFile=C:\Users\test\AppData\Local\Mozilla\Firefox\Profiles\rmu8hqfc.default\shortcutCache\Y7mBbbtNjUwmorbi7zYiJw==.ico
IconIndex=0

--------

So, IE is using 196x196 png favicon, referred here in the page:
>     <link rel="icon" type="image/png" sizes="196x196" href="/media/img/favicon/favicon-196x196.cb79ae3b6daf.png">

Chrome doesn't have any info, but the icon is shown somehow.

Firefox is using cached 48x48 png favicon, not sure where it comes from (maybe generated?),
but the icon looks like white background + 16x16 favicon.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: shortcut icons on Windows 7

Comment 3

[Robert Strong (they/them - no direct email)]

Shell integration doesn't contain the code that does this so moving back to untriaged in the hope that this gets moved to the correct component.

Comment 4

[Tooru Fujisawa [:arai]]

thank you for checking :)

I think I located the place the icon is generated.

https://dxr.mozilla.org/mozilla-central/rev/d5f20820c80514476f596090292a5d77c4b41e3b/widget/windows/WinUtils.cpp#1315
> NS_IMETHODIMP
> AsyncFaviconDataReady::OnComplete(nsIURI *aFaviconURI,
>                                   uint32_t aDataLen,
>                                   const uint8_t *aData, 
>                                   const nsACString &aMimeType)
> {
> ...
>     // Create a 48x48 surface and paint the icon into the central 16x16 rect.
>     size.width = 48;
>     size.height = 48;
>     dataSurface =
>       Factory::CreateDataSourceSurface(size, SurfaceFormat::B8G8R8A8);
> ...
>     dt->FillRect(Rect(0, 0, size.width, size.height),
>                  ColorPattern(Color(1.0f, 1.0f, 1.0f, 1.0f)));
>     dt->DrawSurface(surface,
>                     Rect(16, 16, 16, 16),
>                     Rect(Point(0, 0),
>                          Size(surface->GetSize().width, surface->GetSize().height)));

It clearly says that we're using 48x48 image with 16x16 icon at the center.

Comment 5

[wrhenshaw99]

Is there any chance of this getting fixed?  The tiny icon inside a big white square is really hard for my 66 year old eyes to see.  Can there be an option to use the black and orange icon with the Firefox logo instead?

Thanks,
Bill

Comment 6

[Jutta Koliofotis]

Hello Bill
That would be just as tedious, if only black-orange Firefox icons smile at you! Just like in IE in the past.
However, the icons seem to have become even smaller. Despite workplace glasses, they are no longer recognizable!!!
Can't there be no solution to this problem??

Comment 7

[Tooru Fujisawa [:arai]]

I guess, the design was decided when most favicons were 16x16 ?
bug 110894 comment #111 mentions 100%, not 16x16, I don't remember if the favicon size was the case at that moment.

if 100% is the expected, we could render the original-sized favicon (scale if over 48x48), centered in the box.
https://searchfox.org/mozilla-central/rev/39b790b29543a4718d876d8ca3fd179d82fc24f7/widget/windows/WinUtils.cpp#1297

:shorlander, how do you think?

Comment 8

[wrhenshaw99]

Hello Jutta,
I was just thinking that it would be better than the tiny icon we see now.  It is so small I can't tell what the icon is supposed to represent.  If it was the Firefox icon it would at least let me know it is a favorite shortcut and not some other shortcut.  Making the tiny icon larger so it is the same size as the white square would be good as well.
Thanks,
Bill

Comment 9

[Masatoshi Kimura [:emk]]

Attachment: Do not shrink favicons down to 16x16

By this change, icons will never be shrunk to a smaller size. Windows will do
it appropriately.

Internet Explorer's icon handler will not paint the white background if the
icon is large enough. I'm also replicating the behavior.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13b55e075532
Do not shrink favicons down to 16x16. r=aklotz

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/13b55e075532