129315 - incorrect column definition for bugs.delta_ts

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

The bugs.delta_ts field is defined as being able to contain NULL values, even
though it is initialized to the current date/time when a new record is created
in that table and is never set to NULL.  It should be defined as *not* being
able to contain NULL values.

Comment 1

[Vlad Dascalu]

Attachment: Patch to make delta_ts not null

Comment 2

[Vlad Dascalu]

This patch does not modify the structure of an existing table, I think it
affects only new tables created by checksetup. Modifying the existing ones too
might be overkill and I don't know if that would be needed as well.

Comment 3

[Dave Miller [:justdave]]

Yeah, we can fix old systems when we change it from TIMESTAMP to DATETIME

Comment 4

[Christian Reis]

Comment on attachment 131629 [details] [diff] [review]
Patch to make delta_ts not null

I agree that it's not important to change existing tables, and justdave
confirmed, so r=kiko.

Comment 5

[Vlad Dascalu]

Reassigning to patch writer.

Comment 6

[Christian Reis]

Checked in:

/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.251; previous revision: 1.250

(And vladd chalks another one off!)