1293263 - build docker images (but don't push) as part of CI

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P3)

Description

[[e-mail] (:bhearsum)]

While making a change to the Dockerfile today, I realized that we have no verification that it will actually build (beyond doing a local build) until we merge to master. It would be good to have a job that runs as part of CI that builds the Docker image, but doesn't push it.

Comment 1

[Mercy Muchai]

I would like to work on this issue

Comment 2

[Mercy Muchai]

Does this task mean:
1. The CI should build a docker image on PRs made to master for the verification before merging and not push the image
2. Only on merge will it push the image to Dockerhub

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Mercy Muchai from comment #2)
> Does this task mean:
> 1. The CI should build a docker image on PRs made to master for the
> verification before merging and not push the image
> 2. Only on merge will it push the image to Dockerhub

Hi Mercy,

I actually don't think this is a great task for you -- it's almost exclusively tied to our CI system, and requires the Dockerhub credentials to test properly.

Comment 4

[Mercy Muchai]

Cool. Thank you for the clarification. Let me look into a new issue.

Comment 5

[[e-mail] (:bhearsum)]

We do this now!