1293328 - mozilla::net::NullHttpTransaction supporting weak reference but used on multiple threads

Status: RESOLVED WORKSFORME

(Core :: Networking: HTTP, defect)

Description

[Honza Bambas (:mayhemer)]

m-c with bug 956338 patch v1.1 (soon will be updated with a less strict patch), tho, still worth reporting to at least think about it.

Socket thread:

 	xul.dll!nsSupportsWeakReference::~nsSupportsWeakReference() Line 63	C++
>	xul.dll!mozilla::net::NullHttpTransaction::`scalar deleting destructor'()	C++
 	xul.dll!nsExtProtocolChannel::Release() Line 77	C++
 	xul.dll!mozilla::net::nsHttpConnectionMgr::nsHalfOpenSocket::~nsHalfOpenSocket() Line 2992	C++
 	xul.dll!mozilla::net::nsHttpConnectionMgr::nsHalfOpenSocket::Release() Line 2957	C++
 	xul.dll!mozilla::net::nsSocketOutputStream::OnSocketReady(NS_OK) Line 553	C++
 	xul.dll!mozilla::net::nsSocketTransport::OnSocketReady(0x0fa57480, ) Line 1964	C++
 	xul.dll!mozilla::net::nsSocketTransportService::DoPollIteration() Line 1082	C++
 	xul.dll!mozilla::net::nsSocketTransportService::Run() Line 867	C++
 	xul.dll!nsThread::ProcessNextEvent(true, 0x0663fa3f) Line 1058	C++
 	xul.dll!NS_ProcessNextEvent(, true) Line 290	C++


but was created on the main thread.  There was tho no weakprt proxy created for it.

Comment 1

[Honza Bambas (:mayhemer)]

Note, that on try or locally I was not able to hit multi-thread usage of the _weak proxy_ object (the latest version of the assertion patch from bug 956338).  But that doesn't mean there isn't a code path allowing the concurrent access.

Comment 2

[Honza Bambas (:mayhemer)]

Patrick, I'll need some help to find steps how to trigger the h2/https proxy tunneling.  I've set up an https proxy (squid) via PAC, checked it's working, but can't trigger the code that does actual do_QueryReferent on the transaction (In/OutputStreamShim).

Comment 3

[Patrick McManus [:mcmanus]]

I don't believe squid does https over h2 - which you probably need for that code (it does https over h1/https) to trigger.

nghttp is my goto h2 proxy of choice.

Comment 4

[Honza Bambas (:mayhemer)]

Seems like there are no crashes captured by crash-stats nor we was able to reproduce locally.