1293603 - Fix up a bunch of NS_IMETHOD declarations

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

Some more NS_IMETHOD/NS_IMETHODIMP/NS_METHOD cleanups as precursors to bug 1292440.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Add |override| to CollectReports() declarations missing it

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Make Run() declarations consistent

This patch makes all Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.

As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Remove erroneous NS_METHOD uses in widget/

All these occurrences are for methods declared with NS_IMETHOD, and so they
should be NS_IMETHODIMP instead of NS_METHOD.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4417b2d37bc5b768181b792daccb56c3d29a5d11
Bug 1293603 (part 1) - Add |override| to CollectReports() declarations missing it. r=erahm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b09d90288666fb3afb11877fc45527b904ef23db
Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3660839b76ee6d25836b4c3456103d8e7afe053b
Bug 1293603 (part 3) - Remove erroneous NS_METHOD uses in widget/. r=erahm.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4417b2d37bc5
https://hg.mozilla.org/mozilla-central/rev/b09d90288666
https://hg.mozilla.org/mozilla-central/rev/3660839b76ee