Closed Bug 1293756 Opened 8 years ago Closed 8 years ago

fix "dynamic" requires in autocomplete.js

Categories

(DevTools :: Framework, enhancement, P1)

enhancement

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Iteration:
51.1 - Aug 15
Tracking Status
firefox51 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [reserve-html])

Attachments

(1 file)

There's a bit of code in autocomplete.js that webpack thinks is dynamically
calling require.  Easy to fix and makes webpack happy.
Comment on attachment 8779477 [details]
Bug 1293756 - avoid dynamic requires in autocomplete.js;

https://reviewboard.mozilla.org/r/70456/#review67774
Attachment #8779477 - Flags: review?(bgrinstead) → review+
Iteration: --- → 51.1 - Aug 15
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3030bd212811
avoid dynamic requires in autocomplete.js; r=bgrins
https://hg.mozilla.org/mozilla-central/rev/3030bd212811
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: