Closed Bug 1294290 Opened 8 years ago Closed 8 years ago

Enforce that all places items must have non-null GUIDs

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1294291

People

(Reporter: markh, Unassigned)

References

(Blocks 1 open bug)

Details

Places goes to great lengths to ensure all items have GUIDs, and has a "unique" index on the column. It has DEBUG-only code in Database::Shutdown() that asserts if it finds any NULL items, but best I can tell, this isn't actually enforced.

Doing this would allow Sync to remove some complexity around ensuring items have GUIDs when best I can tell, that's already true, just not enforced.

ISTM this might be as easy as changing the GUID column to be "NOT NULL"?

Mak, is there something I'm missing here?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.