1294486 - Fix inspector textbox-search-clear position in RTL locales

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[magicp]

Attachment: rtl-inspector-textbox-search-clear-position.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160811030201

Steps to reproduce:

1. Start Nightly in RTL locales
2. Open DevTools > Inspector
3. Enter any word into inspector-searchbox
4. Check textbox-search-clear position


Actual results:

textbox-search-clear position is wrong.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=c9bbdb627b7804fee47aa6a6708647e6e589d09c&tochange=3269dd1a824d1b42cb021d1fb6858885179940b0



Expected results:

textbox-search-clear position should be on the left side.

Comment 1

[[e-mail]]

Attachment: Bug 1294486 - Fix inspector textbox-search-clear position in RTL locales;

Review commit: https://reviewboard.mozilla.org/r/71088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71088/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8780361 [details]
Bug 1294486 - Fix inspector textbox-search-clear position in RTL locales;

https://reviewboard.mozilla.org/r/71088/#review69232

Thanks for the patch! Please r=gl me in the commit message.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/76aa2e3efbdd
Fix inspector textbox-search-clear position in RTL locales; r=gl

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/76aa2e3efbdd

Comment 5

[Sayed [:LiquidO2]]

I have reproduced this bug with Nightly 51.0a1 (2016-08-11) in RTL mode(ar) on Elementary OS 64bit. 

This bug's fix is now verified on Latest Nightly 51.0a1 in RTL mode(ar)

build id 	20160817030202
user agent	Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160817]