Closed
Bug 1294553
Opened 8 years ago
Closed 8 years ago
Don't pretend that nsCocoaWindow is an interface in nsPIWidgetCocoa.idl
Categories
(Core :: Widget: Cocoa, defect)
Core
Widget: Cocoa
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
Details
Attachments
(1 file)
Currently, we pretend that nsCocoaWindow is an interface in nsPIWidgetCocoa.idl such that it can be returned from GetChildSheet. This is unnecessary, as the only method which is called on the return value of GetChildSheet appears to be Show, which is a method on nsIWidget. This patch changes nsCocoaWindow to return a nsIWidget instead of a nsCocoaWindow.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8780300 [details] Bug 1294553 - Don't pretend that nsCocoaWindow is an interface in nsPIWidgetCocoa.idl, https://reviewboard.mozilla.org/r/71010/#review68512
Attachment #8780300 -
Flags: review?(mstange) → review+
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9a9a9ea21a18 Don't pretend that nsCocoaWindow is an interface in nsPIWidgetCocoa.idl, r=mstange
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9a9a9ea21a18
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•