1294772 - [FlyWeb] NS_ERROR_FAILURE on 'Nightly' builds for Windows and Linux

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Justin D'Arcangelo [:justindarc]]

The following error is logged to the console when running an official "Nightly" build for Windows or Linux:

Error: [Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "<unknown>"  data: no]

It seems as though the mDNS fallback implementation is not being included in the builds even though this problem does not happen when doing a local build of m-c.

Comment 1

[Kannan Vijayan [:djvj]]

Attachment: fix-nightly-package-components.patch

Test patch.  Waiting on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9aaf49097741

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 8780607 [details] [diff] [review]
fix-nightly-package-components.patch

Yeah, this fixes the issue.  Change is literally adding files to desktop distribution.  I would usually send this to Jonas for review, but Jonas isn't reviewing things anymore.  So I'm r+-ing it myself.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f67dc612d5a6
Add nsDNSServiceDiscovery fallback implementation to desktop package manifest. r=djvj

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee721407a44a
Backout f67dc612d5a6 for OSX build bustage. r=backout

Comment 5

[Kannan Vijayan [:djvj]]

Attachment: fix-nightly-package-components.patch

Previous bustage was due to including un-bundled fallback impl files in the OSX package manifest.  New try looks green on build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a8b244aff24

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fb68854b93a
Add nsDNSServiceDiscovery fallback implementation to desktop package manifest. r=djvj

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2fb68854b93a