1294864 - Move MOZ_PERMISSIONS to python configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1294864 - Move MOZ_PERMISSIONS to Python configure.

Review commit: https://reviewboard.mozilla.org/r/71662/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71662/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8781220 [details]
Bug 1294864 - Move MOZ_PERMISSIONS to Python configure.

https://reviewboard.mozilla.org/r/71662/#review69264

::: old-configure.in
(Diff revision 1)
>  fi
>  
>  AC_SUBST(MOZ_PULSEAUDIO)
>  
>  dnl ========================================================
> -dnl Permissions System

There's a default MOZ_PERMISSIONS=1 set on line 2348. Which means we don't want an "env" for this option since an existing environment variable was ignored.

::: toolkit/moz.configure:449
(Diff revision 1)
>      if places and android_history:
>          die('Cannot use MOZ_ANDROID_HISTORY alongside MOZ_PLACES.')
>  
> +# Permissions system
> +# ==============================================================
> +

we usually don't put an empty line between the "header" and the option()

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8781220 [details]
Bug 1294864 - Move MOZ_PERMISSIONS to Python configure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71662/diff/1-2/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8781220 [details]
Bug 1294864 - Move MOZ_PERMISSIONS to Python configure.

https://reviewboard.mozilla.org/r/71662/#review69662

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04d3df949cab
Move MOZ_PERMISSIONS to Python configure. r=glandium

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/04d3df949cab