1295267 - Deprecated stream.stop() is JS-observably slow at stopping gUM compared to track.stop()

Status: NEW

(Core :: WebRTC: Audio/Video, defect, P4)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STR (in 50+):
1. Open http://jsfiddle.net/oqaofdxq/
2. Share Selected Device.
3. Repeat 4 times (by Hitting "Run" and share again)

Expected output:
- gUM is off

Actual output (most of the time):
- gUM is on

Workaround 1:
- Uncomment stream.getTracks()[0].stop(); instead of stream.stop();

Workaround 2:
- Add a .then(() => new Promise(r => setTimeout(r, 100)) before .then(haveGum)


I don't see any way for JS to exploit this, but it's racy JS-observable behavior we should probably avoid, and it makes writing certain tests ugly, so if there's an easy fix that would be great.

Comment 1

[Andreas Pehrson [:pehrsons]]

Is "MediaStream.stop is old and deprecated, don't use it" not enough?

In all fairness it's from a time when we didn't have MediaStreamTrack.stop so they shouldn't really be mixed.

I don't think there's an easy fix because a MediaStream from gUM doesn't track all its tracks' clones, which would also have to be stopped.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I suspect it will be with us for a while, given that Chrome has yet to pivot to tracks, so we may want to fix JS observable behavior. Not a big deal I agree, as long as we're ok with removing excess uses in our tests (except one I suppose). I filed it in case it was easy to fix.

Comment 3

[Andreas Pehrson [:pehrsons]]

Well, they haven't for RTCPeerConnection, but they seem ok from getUserMedia. At least Chrome 52 doesn't have MediaStream.stop().

Comment 4

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.