Closed
Bug 1295340
Opened 8 years ago
Closed 8 years ago
Update copy for "Custom Tabs" in Settings
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Firefox for Android Graveyard
General
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: antlam, Assigned: sebastian)
References
Details
(Whiteboard: [MobileAS])
Attachments
(1 file)
Our copy for the Custom Tabs setting is not consistent with the rest of our language. Let's fix this. Michelle, do you have any thoughts on this? Custom Tabs [1] seems to be the right label, but I'm not sure about the description. Current: Custom Tabs Allow third party apps to open URLs with a customized look and feel Proposed: Custom Tabs [1] https://developer.chrome.com/multidevice/android/customtabs
|
Assignee | |
Comment 2•8 years ago
|
||
Note that this is a Nightly only setting and is unlikely to ship. (Right now the feature is too broken to be enabled by default, that's why we are showing a setting for devs/testers in Nightly).
Custom Tabs Allow apps to open websites using a customized version of Firefox
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Flags: needinfo?(s.kaspari)
| Comment hidden (mozreview-request) |
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8798501 [details] Bug 1295340 - Custom tabs string: Use &brandShortName; instead of 'Firefox'. https://reviewboard.mozilla.org/r/83972/#review82624
Attachment #8798501 -
Flags: review?(gkruglov) → review+
Pushed by s.kaspari@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ff08c7cfb55d Update copy for "Custom Tabs" in Settings. r=Grisha
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ff08c7cfb55d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
|
Assignee | |
Comment 10•8 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #9) > Are you use you want Firefox instead of &brandShortName;? Oh, damn. This should be &brandShortName; of course. Should I update the key again when changing that (pref_custom_tabs_summary2 -> pref_custom_tabs_summary3)?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 11•8 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #10) > Oh, damn. This should be &brandShortName; of course. Should I update the key > again when changing that (pref_custom_tabs_summary2 -> > pref_custom_tabs_summary3)? At this point yes, you need an updated string ID.
| Comment hidden (mozreview-request) |
|
|
||
Comment 13•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8798501 [details] Bug 1295340 - Custom tabs string: Use &brandShortName; instead of 'Firefox'. https://reviewboard.mozilla.org/r/83972/#review83716
Attachment #8798501 -
Flags: review?(francesco.lodolo) → review+
|
||
Comment 14•8 years ago
|
||
Pushed by s.kaspari@gmail.com: https://hg.mozilla.org/integration/autoland/rev/70249b325a4e Custom tabs string: Use &brandShortName; instead of 'Firefox'. r=flod,Grisha
|
|
Assignee | |
Updated•8 years ago
|
Priority: -- → P1
Whiteboard: [MobileAS]
|
||
Comment 15•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/70249b325a4e
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Iteration: --- → 1.6
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•