12959 - [TEXT] delete text with negative char spacing doesn't display correctly

Status: RESOLVED WONTFIX

(Core :: Layout, defect, P4)

Description

[buster]

open sample 0
turn on edit mode
select at the end of the paragraph that has negative character spacing on the
first line
start backspacing
when you get to a single line of text, notice the display turds left where the
characters used to be

Comment 1

[kipp]

I suspect troy will be able to fix this up lickety split since it has to (most
likely) do with incremental reflow and insufficient invalidation...

Comment 2

[troy]

Kipp, as Steve indicated this problem only happens when there's negative spacing
involved. It looks to me like maybe the line's "combined rect" is incorrect in
that case and that's why we end up not erasing everything

The block code in ReflowLine() is erasing everything, because we really don't
know what changed:

    // We don't really know what changed in the line, so use the union
    // of the old and new combined areas
    if (aDamageDirtyArea) {
      nsRect  dirtyRect;

      dirtyRect.UnionRect(oldCombinedArea, aLine->mCombinedArea);
      Invalidate(dirtyRect);
    }

I would guess the problem is wherever we handle negative character spacing.
Maybe it's round off error?

Comment 3

[kipp]

I hate bouncing bugs. Oh well.

Comment 4

[kipp]

Well, I can't reproduce it on linux, so it'll have to wait until I have access
to a windoze box to see whats up...

Comment 5

[leger]

Updating to default Layout Assignee...kipp no longer with us :-(

Comment 6

[troy]

Why are you re-reassing layout bugs? Do NOT touch layout bugs.

The bugs are assigned to Kipp so they can stay neatly organized until we have a
new owner for the block/inline code.

Comment 7

[buster]

mine! mine mine mine!  all mine!  whoo-hoo!

Comment 8

[buster]

Here is the initial batch of layout [TEXT] bugs.  I'll search for more today, 
but this should keep you busy for a while!

Please review these for possible dogfood or nsbeta2 candidates, and assign your 
own priority and milestone for each.  The current settings were relative to my 
bug list, and they might not make sense any more.

Comment 9

[Erik van der Poel]

I confirmed that this bug still exists. Marking M19.

Comment 10

[Frank Tang]

Mark this as future since no real user will use negative char spacing in real 
life and edit them anyway.

Comment 11

[Frank Tang]

erik resign. reassign all his bug to ftang for now.

Comment 12

[Frank Tang]

mark all future new as assigned after move from erik to ftang

Comment 13

[Frank Tang]

mark this bug as wontfix