1295920 - Replace enum with enum class in PlatformDecoderModule.h

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[James Cheng[:JamesCheng]]

Use enum class instead of enum for memory saving.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1295920 - Replace enum with enum class in PlatformDecoderModule.h.

Review commit: https://reviewboard.mozilla.org/r/72248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72248/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

How does enum class save more memory than enum?

Comment 3

[James Cheng[:JamesCheng]]

(In reply to JW Wang [:jwwang] from comment #2)
> How does enum class save more memory than enum?
More specifically,
using enum class : uint8_t instead of enum (integer) to save memory.
Another reason is using strong type |enum class| is more encouraged.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

The memory saving (which is quite insignificant unless they are stored in an array) doesn't justify this bug as much as strong typing.

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8781933 [details]
Bug 1295920 - Replace enum with enum class in PlatformDecoderModule.h.

https://reviewboard.mozilla.org/r/72248/#review70090

Assuming it all compiles on all platform of course...

Comment 6

[James Cheng[:JamesCheng]]

Thanks for reviewing.

It can be compiled in all platforms.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2037ad7fcb1

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82cacf7d008a
Replace enum with enum class in PlatformDecoderModule.h. r=jya

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/82cacf7d008a