1296295 - dom/media/platforms/gonk/GonkDecoderModule.cpp:43:12: error: 'kNeedAnnexB' was not declared in this scope

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=82cacf7d008ad5bce4cfee7aa4006ef95407a0ae&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=2146596

Comment 1

[:gerard-majax]

Attachment: Bug 1296295 - Followup bug 1295920, replace enum with enum class

Review commit: https://reviewboard.mozilla.org/r/72622/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72622/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8782451 [details]
Bug 1296295 - Followup bug 1295920, replace enum with enum class

https://reviewboard.mozilla.org/r/72622/#review70242

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5722cb5f4d22
Followup bug 1295920, replace enum with enum class r=jya

Comment 4

[James Cheng[:JamesCheng]]

Hi Alexandre,

Could you please tell me how to ensure the tier3 platform can be built on try server?

I had pushed a try to validate all the platforms can pass the build [1], but it seems the error log from tier3 will be various in different errors... it is hard to notice the build fail case which is due to the patch we provide.

Is there any good way to do ensure this? 


Thank you and thanks for fixing this!

[1]https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8996c98fd88&filter-tier=1&filter-tier=2&filter-tier=3

Comment 5

[:gerard-majax]

Well, your link *should* have been good. Now, being tier 3 means we get broken more easily. In this case, what happens is that we thought we moved everything away from git.mozilla.org which was decommissionned a couple of days ago. Turns out we forgot a couple of references to it, and this broke builds. Hence the failure we can see in your log. Generally speaking, your approach should have worked. In this case, however, bad luck came into play :/

But thanks for trying to not break this!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5722cb5f4d22