1296301 - Source operator not optimized in DrawTargetSkia when mask bounds larger than clip

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Lee Salzman [:lsalzman]]

Attachment: use getClipDeviceBounds instead of getClipBounds in DrawTargetSkia

With respect to the mask bounds optimization at: https://dxr.mozilla.org/mozilla-central/source/gfx/2d/DrawTargetSkia.cpp#441

This never gets triggered because the clip bounds are slightly inflated by Skia as done here: https://dxr.mozilla.org/mozilla-central/source/gfx/skia/skia/src/core/SkCanvas.cpp#1809

This causes us to always push a layer for unbounded operators, even when we shouldn't need one.

The simplest fix is just to use getClipDeviceBounds instead so we can skip this inflation.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8782463 [details] [diff] [review]
use getClipDeviceBounds instead of getClipBounds in DrawTargetSkia

Review of attachment 8782463 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/DrawTargetSkia.cpp
@@ +398,5 @@
>  static inline Rect
>  GetClipBounds(SkCanvas *aCanvas)
>  {
> +  // Use getClipDeviceBounds instead of getClipBounds to avoid
> +  // inflation of the bounds rect.

// Use a manually transformed getClipDeviceBounds instead of
// getClipBounds because getClipBounds inflates the the bounds
// by a pixel in each direction to compensate for antialiasing.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Great find and patch.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91667ea2a01e
use getClipDeviceBounds instead of getClipBounds in DrawTargetSkia. r=jrmuizel

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/91667ea2a01e