1296502 - js-config contains the python representation of a list for NSPR_CFLAGS

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

NSPR_CFLAGS='['-I(...)/obj-x86_64-pc-linux-gnu/dist/include/nspr']'

is what this looks like in js-config. This is a regression from bug 1229541.

The problem is that we're feeding raw substs values to the preprocessor:
https://dxr.mozilla.org/mozilla-central/rev/97a52326b06a07930216ebefa5af333271578904/python/mozbuild/mozbuild/backend/base.py#244

The preprocessor then goes on to convert the values to strings when apply the substitution filter:
https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/preprocessor.py#728

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1296502 - Serialize lists when preparing a context for the preprocessor in build backends.

Some substs values are lists, and some CONFIGURE_SUBST_FILES use them,
and don't expect the substitution to use a pythonic expression of the
value. So serialize those lists.

Review commit: https://reviewboard.mozilla.org/r/72784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72784/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8782736 [details]
Bug 1296502 - Serialize lists when preparing a context for the preprocessor in build backends.

https://reviewboard.mozilla.org/r/72784/#review70700

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3edbba2eb8a
Serialize lists when preparing a context for the preprocessor in build backends. r=gps

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c3edbba2eb8a