1296506 - Rename some method names which look for an editable node

Status: RESOLVED WORKSFORME

(Core :: DOM: Editor, task, P5)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Some methods in editor look for a editable node, but it's not explained by the method name. So, we should rename them as:

* HTMLEditor::GetNextHTMLNode() -> HTMLEditor::GetNextEditableNode()
* HTMLEditor::GetPriorHTMLNode() -> HTMLEditor::GetPrevEditableNode()
* HTMLEditor::GetNextHTMLSibling() -> HTMLEditor::GetNextEditableSibling()
* HTMLEditor::GetPriorHTMLSibling() -> HTMLEditor::GetPrevEditableSibling()

(I like "Prev" better than "Prior" because a lot of code use it as opposite word of "Next" and it's same length as "Next".)

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

The first two also only return leaf nodes, which is practically speaking an even more critical detail, so I suggest GetPrev/NextEditableLeafNode() for the first two.  Otherwise agreed.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thanks you. I'll suggest to use this bug in Hacker event of Mozilla Japan at this weekend.

Comment 3

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, 4 years untouched DOM/Storage bugs' priority.

If you have reason to believe this is wrong (especially for the severity), please write a comment and ni :jstutte.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, the sacn utility methods have an option argument which is self-documenting.