1296739 - gfxPlatform::GetParentDevicePrefs is protected, but invalidly called outside of gfxPlatform

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Nathan Froyd [:froydnj]]

clang-cl complains about gfxPlatform::GetParentDevicePrefs:

 4:16.97 In file included from C:/m-c/obj-clang-cl-optimized/gfx/thebes/Unified_cpp_gfx_thebes0.cpp:20:
 4:16.97 c:/m-c/gfx/thebes/DeviceManagerD3D11.cpp(108,35):  error: 'GetParentDevicePrefs' is a protected member of 'gfxPlatform'
 4:16.97       gfxPlatform::GetPlatform()->GetParentDevicePrefs().d3d11TextureSharingWorks();
 4:16.97                                   ^
 4:16.97 c:/m-c/gfx/thebes/gfxPlatform.h(740,42):  note: declared protected here
 4:16.97     static mozilla::gfx::DeviceInitData& GetParentDevicePrefs();
 4:16.97                                          ^
 4:16.97 In file included from C:/m-c/obj-clang-cl-optimized/gfx/thebes/Unified_cpp_gfx_thebes0.cpp:20:
 4:16.97 c:/m-c/gfx/thebes/DeviceManagerD3D11.cpp(155,35):  error: 'GetParentDevicePrefs' is a protected member of 'gfxPlatform'
 4:16.97       gfxPlatform::GetPlatform()->GetParentDevicePrefs().adapter();
 4:16.98                                   ^
 4:16.98 c:/m-c/gfx/thebes/gfxPlatform.h(740,42):  note: declared protected here
 4:16.98     static mozilla::gfx::DeviceInitData& GetParentDevicePrefs();
 4:16.98                                          ^
 4:16.98 In file included from C:/m-c/obj-clang-cl-optimized/gfx/thebes/Unified_cpp_gfx_thebes0.cpp:20:
 4:16.98 c:/m-c/gfx/thebes/DeviceManagerD3D11.cpp(469,33):  error: 'GetParentDevicePrefs' is a protected member of 'gfxPlatform'
 4:16.98     gfxPlatform::GetPlatform()->GetParentDevicePrefs().adapter();
 4:16.98                                 ^
 4:16.98 c:/m-c/gfx/thebes/gfxPlatform.h(740,42):  note: declared protected here
 4:16.98     static mozilla::gfx::DeviceInitData& GetParentDevicePrefs();
 4:16.98                                          ^

I don't know exactly how MSVC permits this to compile, but it is blocking attempts at compiling with clang-cl.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 1296739: Change the protected to public, clang complaining.

Review commit: https://reviewboard.mozilla.org/r/73312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73312/

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

David, I'm not sure if you'd rather make this method public, or DeviceManagerD3D11 a friend, or some other alternative.  The patch just makes this method public.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

This *should* be obsoleted by bug 1294988 which removes GetParentDevicePrefs. If I'm wrong just re-open.