Closed
Bug 1296929
Opened 8 years ago
Closed 8 years ago
Match spec for col/colgroup.span, textarea.rows/cols
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: ayg, Assigned: ayg)
Details
Attachments
(1 file)
|
13.63 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
https://github.com/whatwg/html/pull/1693 In brief, we and Edge throw for textarea.rows/cols, which is what the spec used to say. The spec changed to match Blink and WebKit, who don't throw, because it's not nice to ask anyone to start throwing. There were a bunch of other inconsistencies between UAs here, and I reviewed what the new spec says against implementations and it seems to be reasonable, so I suggest we change to match it. (This will also affect col/colgroup.span, which we already didn't throw for.)
|
Assignee | |
Comment 1•8 years ago
|
||
Tests upstream: https://github.com/w3c/web-platform-tests/pull/3518
|
||
Updated•8 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=28f91bef1c85&exclusion_profile=false Failures were fixed in the attached patch.
|
||
Updated•8 years ago
|
Attachment #8783488 -
Flags: review?(jst) → review+
Pushed by ayg@aryeh.name: https://hg.mozilla.org/integration/mozilla-inbound/rev/1442a6ab4296 Match spec for col/colgroup.span, textarea.rows/cols; r=jst
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1442a6ab4296
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•