1297518 - Intermittent toolkit/components/url-classifier/tests/mochitest/test_bug1254766.html | Should not import bad css - didn't expect "hidden", but got it

Status: RESOLVED FIXED

(Toolkit :: General, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=34509383&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/CXdvdV9BRUKLwSDZo7dMDg/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[Intermittent Failures Robot]

14 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 8
* autoland: 4
* try: 1
* mozilla-central: 1

Platform breakdown:
* android-4-3-armv7-api15: 14

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1297518&startday=2016-08-22&endday=2016-08-28&tree=all

Comment 2

[Dimi Lee [:dimi]]

Working on this bug right now

Comment 3

[Dimi Lee [:dimi]]

The root cause is that in certain platform(Android in this case), http request, response may take longer than expect.

In test_gethash.html and test_bug1254766.html we will use |gethash.sjs| to simulate gethash server, but if the response takes long than the timeout threshold[1], then the testcase will fail.

I think we don't have to care about gethash timeout for testcases, so the solution here is just increase the timeout value.

[1] https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierHashCompleter.js#358

Comment 4

[Dimi Lee [:dimi]]

Attachment: Bug 1297518 - Increase gethash timeout for testcases.

Review commit: https://reviewboard.mozilla.org/r/75990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75990/

Comment 5

[BMO Automation]

Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.

Comment 6

[Henry Chang [:hchang]]

Comment on attachment 8787131 [details]
Bug 1297518 - Increase gethash timeout for testcases.

Brilliant finding! Thanks!

Comment 7

[Dimi Lee [:dimi]]

Comment on attachment 8787131 [details]
Bug 1297518 - Increase gethash timeout for testcases.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/75990/diff/1-2/

Comment 8

[Intermittent Failures Robot]

37 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 15
* autoland: 9
* try: 8
* mozilla-central: 3
* fx-team: 2

Platform breakdown:
* android-4-3-armv7-api15: 36
* android-api-15-gradle: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1297518&startday=2016-08-29&endday=2016-09-04&tree=all

Comment 9

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8787131 [details]
Bug 1297518 - Increase gethash timeout for testcases.

https://reviewboard.mozilla.org/r/75990/#review74874

Comment 10

[Dimi Lee [:dimi]]

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a44d7352424

Comment 11

[Dimi Lee [:dimi]]

Comment on attachment 8787131 [details]
Bug 1297518 - Increase gethash timeout for testcases.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/75990/diff/2-3/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/223b9a23f373
Increase gethash timeout for testcases. r=gcp

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/223b9a23f373

Comment 14

[Intermittent Failures Robot]

14 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 7
* mozilla-central: 3
* autoland: 3
* fx-team: 1

Platform breakdown:
* android-4-3-armv7-api15: 14

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1297518&startday=2016-09-05&endday=2016-09-11&tree=all