Closed Bug 1297545 Opened 8 years ago Closed 6 years ago

improve handling of massive diffs (avoid slow script dialog)

Categories

(MozReview Graveyard :: General, defect)

Product:
MozReview Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: tnikkel, Unassigned)

References

Details

Load https://reviewboard.mozilla.org/r/64314/diff/2#index_header and you get a slow script warning. Reproduces in fresh profile and in nightly and 45. It never seems to recover.
what's causing this is the size of the patch: 111,141 insertions; 8,163 deletions.

we should catch when a diff might be too large to review (i suspect experimentation will be required to find the right value), and instead show a link to the raw diff (https://reviewboard-hg.mozilla.org/gecko/raw-rev/85572a505fb2 in this case).
Summary: slow script dialog → improve handling of massive diffs (avoid slow script dialog)
Almost certainly a dupe of other dependencies of this blocker, but we'll sort that out later.
Blocks: 1288133
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.