Closed
Bug 1297661
Opened 8 years ago
Closed 8 years ago
Misleading indentation in accessible/base/Logging.cpp
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: nical, Assigned: tbsaunde)
References
Details
Attachments
(1 file)
|
1.43 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Here: http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/accessible/base/Logging.cpp#117 Introduced by this commit: http://searchfox.org/mozilla-central/diff/158a12ab7262e092896e8446d60e36929cfacaa1/accessible/src/base/Logging.cpp#111 Looking at the hg history, it isn't clear to me that "[failed]" should be printed at all, it should probably be removed. I don't know this code so I am not sure, though.
|
||
Comment 1•8 years ago
|
||
[failed] should be removed
|
Assignee | |
Comment 2•8 years ago
|
||
ugh, silly regression to put in :(
Attachment #8784354 -
Flags: review?(bugs)
|
||
Updated•8 years ago
|
Attachment #8784354 -
Flags: review?(bugs) → review+
Pushed by tsaunders@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b78eab191453 remove printf that was useless after bug 939049 r=smaug
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b78eab191453
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
||
Updated•8 years ago
|
Assignee: nobody → tbsaunde+mozbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•