Closed Bug 1297951 Opened 8 years ago Closed 8 years ago

Sylaps

Categories

(Firefox Graveyard :: Screen Sharing Whitelist, defect)

Product:
Firefox Graveyard
Component:
Screen Sharing Whitelist
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox49 fixed, firefox50 fixed, firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox49 --- fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: hthetiot, Assigned: mreavy)

Details

Attachments

(1 file)

sylaps.patch
6.43 KB, patch
jesup
: review+
ritu
: approval-mozilla-aurora+
lizzard
: approval-mozilla-beta+
Details | Diff | Splinter Review 
>> Vendor name
Sylaps

>> Point of contact
support@sylaps.com

>> Site URLs
https://sylaps.com
https://*.sylaps.com

>> Does the application provide users with notice and control?
https://sylaps.com/terms

>> Have you seen and agree with the Developer Screen Sharing Submission policy?
Yes

>> Does the usage comply with the Developer Screen Sharing Submission Policy guidelines?
Yes
Following-up on this mail to get attention as it is important for Qwant business in the next quarter.
+ for going ahead to add to the list Maire.
Flags: needinfo?(mreavy)
Attached patch sylaps.patch — — Splinter Review 
Randell -- Can you review and land this? Thanks.
Flags: needinfo?(mreavy)
Attachment #8785447 - Flags: review?(rjesup)
Assignee: nobody → mreavy
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #8785447 - Flags: review?(rjesup) → review+
Comment on attachment 8785447 [details] [diff] [review]
sylaps.patch

Approval Request Comment
[Feature/regressing bug #]: screensharing whitelist 
[User impact if declined]: Sylaps/Quant needs their domain added to the whitelist to allow screensharing and to avoid having users modify settings in about: config.  They are deploying their service, and they'd like it to work with Firefox so they can promote it working in Firefox.
[Describe test coverage new/current, TreeHerder]: manually verified (it's a text only change)
[Risks and why]: Extremely low risk, very easily verified, pref only change.  It would help Sylaps/Quant tremendously to have this in Firefox 49 to coincide with their new features/service.  They are launching in Q4 and want to promote their product/service working in Firefox.
[String/UUID change made/needed]: No strings
Attachment #8785447 - Flags: approval-mozilla-beta?
Attachment #8785447 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/f18100fdf2ae
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
I can see target milestone is Firefox 51, we talked about Firefox 50. Any chance to get this fix in Firefox 50 at the latest ?
Comment on attachment 8785447 [details] [diff] [review]
sylaps.patch

Makes sense, Aurora50+
Attachment #8785447 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8785447 [details] [diff] [review]
sylaps.patch

Fine for beta uplift as well, adding support for some domains to the whitelist.
Attachment #8785447 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: