1298161 - android.os.StrictMode$InstanceCountViolation: class org.mozilla.gecko.BrowserApp

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

When we recreate BrowserApp instances, previous instances are leaked as shown by InstanceCountViolation in the logcat, e.g.,

> android.os.StrictMode$InstanceCountViolation: class org.mozilla.gecko.BrowserApp; instances=nnn; limit=1

I looked through a memory profile and there were several sources of leaks.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: a. Fix BrowserApp leak in GeckoAccessibility (v1)

Move registration of AccessibilityManager listeners to GeckoApplication,
and change all Context references to the application context, so that
GeckoAccessibility doesn't leak old BrowserApp instances as new
BrowserApp instances are created.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: b. Fix BrowserApp leaks in event registration (v1)

Unregister certain events in BrowserApp and GeckoApp to prevent
BrowserApp from leaking. Also, properly unregister event listeners in
PageActionLayout to prevent BrowserApp leaks, because
PageActionLayout.onDestroy never got called before.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: c. Properly remove pref handler in NativePanZoomController (v1)

Properly remove pref handler on destroy to prevent leaking BrowserApp.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: d. Use application context to prevent BrowserApp leaks (v1)

Use application context for delayed callbacks to prevent leaking the
BrowserApp instance. Also, use application context for accessing
Distribution, to prevent leaking old BrowserApp instances, and to avoid
using a destroyed Context. Finally, attach AudioFocusAgent to the
application context instead of the BrowserApp context to avoid leaking
BrowserApp.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Awesome!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/18a92c5e14e6
a. Fix BrowserApp leak in GeckoAccessibility; r=sebastian
https://hg.mozilla.org/integration/fx-team/rev/2c6691bd8a71
b. Fix BrowserApp leaks in event registration; r=sebastian
https://hg.mozilla.org/integration/fx-team/rev/322bce6bc1d6
c. Properly remove pref handler in NativePanZoomController; r=rbarker
https://hg.mozilla.org/integration/fx-team/rev/803dba6b6691
d. Use application context to prevent BrowserApp leaks; r=sebastian

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/18a92c5e14e6
https://hg.mozilla.org/mozilla-central/rev/2c6691bd8a71
https://hg.mozilla.org/mozilla-central/rev/322bce6bc1d6
https://hg.mozilla.org/mozilla-central/rev/803dba6b6691