1298536 - Move --with-linux-headers to Python configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1298536 - Allow flags passed to try_compile to be a depends function.

Review commit: https://reviewboard.mozilla.org/r/74662/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74662/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1298536 - Move --with-linux-headers to Python configure.

Review commit: https://reviewboard.mozilla.org/r/74664/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74664/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8785492 [details]
Bug 1298536 - Allow flags passed to try_compile to be a depends function.

https://reviewboard.mozilla.org/r/74662/#review73448

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8785493 [details]
Bug 1298536 - Move --with-linux-headers to Python configure.

https://reviewboard.mozilla.org/r/74664/#review73450

::: build/moz.configure/headers.configure:65
(Diff revision 1)
>      'netinet/in.h',
>      'byteswap.h',
>      when=non_msvc_compiler,
>  )
> +
> +have_perf_event_h = check_header('linux/perf_event.h',

Can you add a TODO that this needs to move in a --enable-project=js specific file?

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8785492 [details]
Bug 1298536 - Allow flags passed to try_compile to be a depends function.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/74662/diff/1-2/

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8785493 [details]
Bug 1298536 - Move --with-linux-headers to Python configure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/74664/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4df9ee747c3
Allow flags passed to try_compile to be a depends function. r=glandium
https://hg.mozilla.org/integration/autoland/rev/3f398fa60de0
Move --with-linux-headers to Python configure. r=glandium

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a4df9ee747c3
https://hg.mozilla.org/mozilla-central/rev/3f398fa60de0