1298767 - Allow the tab queue prompt to stay visible longer

Status: RESOLVED INACTIVE

(Firefox for Android Graveyard :: Overlays, defect, P3)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I often don't notice the tab queue prompt because I tap a link and then glance away from my phone, and miss the three seconds that the prompt is visible. I'd like to be able to customize the duration of the overlay.

I guess it's this? https://dxr.mozilla.org/mozilla-central/rev/1a5b53a831e5a6c20de1b081c774feb3ff76756c/mobile/android/base/java/org/mozilla/gecko/tabqueue/TabQueueService.java#72

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

We had increased this previously with bug 1246707

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Kevin Brosnan [:kbrosnan] from comment #1)
> We had increased this previously with bug 1246707

That patch changed snackbars from LENGTH_SHORT to LENGTH_LONG, but didn't appear to touch the timeout in the file/line I linked in comment 0. According to http://stackoverflow.com/questions/2220560/can-an-android-toast-be-longer-than-toast-length-long/5079536#5079536 the default values for LENGTH_SHORT and LENGTH_LONG are 2 and 3.5 seconds, respectively. 

Would there be any objections to simply increasing the TOAST_TIMEOUT value from 3 seconds to 4 or 5 seconds?

I tried[1][2] to add a preference to let people customize the delay, but I'm clearly not very good at writing correct java because the build and the linter failed with that patch.

1. https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d90aa67daae&selectedJob=27546684
2. https://hg.mozilla.org/try/rev/2388caa169ad3b289eb0c8627c0453b54339bc33

Comment 3

[Firefox Bug Husbandry Bot]

Closing per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Contact :susheel if you think this bug should be re-opened